HPC-9997: Simplify support array in PLAN_ENTITY_VERSION_VALUE codec
#202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pl217
added
ready for review
enxtur
approved these changes
Jan 13, 2025
enxtur
added
ready for merge
After fixing database records so that `support` array is initialized everywhere and it can no longer have object with key `"0"`, we can simplify the codec `PLAN_ENTITY_VERSION_VALUE`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
To be merged after admin command from https://github.com/UN-OCHA/hpc_service/pull/3684 is run
After fixing database records so that
supportarray is initialized everywhere and it can no longer have object with key"0", we can simplify the codecPLAN_ENTITY_VERSION_VALUE