Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RW-928] both feedback modes + new column #21

Merged
merged 7 commits into from
Apr 3, 2024
Merged

[RW-928] both feedback modes + new column #21

merged 7 commits into from
Apr 3, 2024

Conversation

rupl
Copy link
Contributor

@rupl rupl commented Apr 2, 2024 •
edited
Loading

Refs: RW-928

  • New config option for feedback mode: both
  • Tweaks to form to allow both feedback modes to co-exist.
  • New column on logs table exclusively for thumbs up/down.
  • New function inside thumbs up/down callback to store data.

I had some weird trouble with the config form so even though I added very little to the config form, please make sure I didn't screw it up.

@rupl rupl requested a review from orakili April 2, 2024 14:06
orakili
orakili approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@orakili orakili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the 3 modes. Working well.

@rupl rupl merged commit 945d071 into develop Apr 3, 2024
2 checks passed
@rupl rupl deleted the RW-928 branch April 3, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orakili orakili orakili approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rupl @orakili