Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RW-1006] Submit question when pressing enter in the question textarea #50

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

orakili
Copy link
Contributor

@orakili orakili commented Jul 8, 2024

Refs: RW-1006

Submit the question when pressing enter in the question textarea.

Tests

  1. Make sure to have the ocha_ai use this PR's branch (add - "../../ocha_ai:/srv/www/html/modules/contrib/ocha_ai:ro" for example in the local/docker.compose.yml).
  2. Clear the cache
  3. Open a report on your local RW (do a hard refresh to make sure the ocha_form.js is the newest version)
  4. Open the chat popup, type a question
  5. Still in the textare, press shift + enter to confirm, you can add a new line
  6. Press enter and confirm that is submits the question

@orakili orakili requested a review from lazysoundsystem July 8, 2024 12:09
Copy link

github-actions bot commented Jul 8, 2024

Monitor coverage for Drupal 10.3.x - PHP 8.2

Totals Coverage
Statements: 87.88% ( 116 / 132 )
Methods: 25% ( 2 / 8 )
Lines: 91.94% ( 114 / 124 )

Copy link

github-actions bot commented Jul 8, 2024

Monitor coverage for Drupal 10.2.x - PHP 8.2

Totals Coverage
Statements: 87.88% ( 116 / 132 )
Methods: 25% ( 2 / 8 )
Lines: 91.94% ( 114 / 124 )

Copy link

github-actions bot commented Jul 8, 2024

Monitor coverage for Drupal 10.3.x - PHP 8.3

Totals Coverage
Statements: 87.88% ( 116 / 132 )
Methods: 25% ( 2 / 8 )
Lines: 91.94% ( 114 / 124 )

Copy link

github-actions bot commented Jul 8, 2024

Monitor coverage for Drupal 10.2.x - PHP 8.3

Totals Coverage
Statements: 87.88% ( 116 / 132 )
Methods: 25% ( 2 / 8 )
Lines: 91.94% ( 114 / 124 )

Copy link
Contributor

@lazysoundsystem lazysoundsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described.

Note that the separate paragraph in the text area isn't reflected in the quoted question - but I don't think that matters.

@orakili orakili merged commit da7460a into develop Jul 8, 2024
10 checks passed
@lazysoundsystem lazysoundsystem deleted the RW-1006 branch July 9, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants