Skip to content
This repository has been archived by the owner on Aug 19, 2020. It is now read-only.

CD-46 image directories #24

Merged
merged 4 commits into from
Aug 13, 2018
Merged

CD-46 image directories #24

merged 4 commits into from
Aug 13, 2018

Conversation

left23
Copy link
Contributor

@left23 left23 commented Aug 13, 2018

img directory in theme root includes all favicon pngs and homescreen images, logos and icons folders.
Only exceptions are theme screenshot and favicon.ico which remain in the root.

Change paths to reflect new structure where background images are being set in css
Change paths in template.php html preprocess and manifest alter hooks

To test, I compiled all css and checked for missing icons or image.

@left23 left23 requested a review from rupl August 13, 2018 12:16
@left23 left23 self-assigned this Aug 13, 2018
src: url('../img/icons/unocha-icons.eot?jb5mn9#iefix') format('embedded-opentype'),
url('../img/icons/unocha-icons.ttf?jb5mn9') format('truetype'),
url('../img/icons/unocha-icons.woff?jb5mn9') format('woff'),
url('../img/icons/unocha-icons.svg?jb5mn9#unocha-icons') format('svg');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

irony, fonts in an image directory 🙃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha. I thought the same to myself. Not for long though :)

Copy link
Contributor

@rupl rupl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 💯 nice work!

@rupl rupl merged commit fd3de32 into master Aug 13, 2018
@rupl rupl deleted the cd-46-image-directories branch August 13, 2018 12:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants