Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CD-520: Update base theme to use x logo #268

Merged
merged 1 commit into from
Nov 27, 2023
Merged

CD-520: Update base theme to use x logo #268

merged 1 commit into from
Nov 27, 2023

Conversation

left23
Copy link
Contributor

@left23 left23 commented Nov 27, 2023

Update to v9.2.2 which includes the X logo to replace Twitter. See https://github.com/UN-OCHA/common_design/releases/tag/v9.2.2

To test

A visual code review and merge to dev where I will check it
Or run composer install to get base theme version update, then clear cache.

Expected result:
Selection_098

Refs: CD-520

@left23 left23 self-assigned this Nov 27, 2023
@left23 left23 requested a review from orakili November 27, 2023 17:33
Copy link

Coverage Report

Totals Coverage
Statements: 0% ( 0 / 42 )
Lines: 0% ( 0 / 42 )

Copy link

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions PHP 8.2.13 (cli) (built: Nov 24 2023 08:47:18) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.13, Copyright (c) Zend Technologies with Zend OPcache v8.2.13, Copyright (c), by Zend Technologies with Xdebug v3.2.1, Copyright (c) 2002-2023, by Derick Rethans Composer version 2.6.5 2023-10-06 10:11:52
Drupal Logs

Pusher: @left23, Action: pull_request, Workflow: Run tests

@orakili orakili merged commit c23c78c into develop Nov 27, 2023
@orakili
Copy link
Contributor

orakili commented Nov 27, 2023

Deployed to dev and X icon is showing as expected.

@lazysoundsystem lazysoundsystem deleted the CD-520-x branch February 13, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants