Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Switch to gtm_barebones #312

Merged
merged 3 commits into from
Apr 24, 2024
Merged

chore: Switch to gtm_barebones #312

merged 3 commits into from
Apr 24, 2024

Conversation

attiks
Copy link
Contributor

@attiks attiks commented Apr 24, 2024 •
edited by jira bot
Loading

Replace google_tag with gtm_barebones

Refs: OPS-10039

@attiks attiks requested a review from lazysoundsystem April 24, 2024 09:44
@github-actions GitHub Actions
Copy link

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions PHP 8.2.17 (cli) (built: Mar 16 2024 08:42:08) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.17, Copyright (c) Zend Technologies with Zend OPcache v8.2.17, Copyright (c), by Zend Technologies with Xdebug v3.3.1, Copyright (c) 2002-2023, by Derick Rethans Composer version 2.7.2 2024-03-11 17:12:18
Drupal Logs

Pusher: @attiks, Action: pull_request, Workflow: Run tests

lazysoundsystem
lazysoundsystem requested changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@lazysoundsystem lazysoundsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this include the gtm_barebones sensor not the google_tag one?

@github-actions GitHub Actions
Copy link

Coverage Report

Totals Coverage
Statements: 0% ( 0 / 42 )
Lines: 0% ( 0 / 42 )

@attiks attiks merged commit e79c354 into develop Apr 24, 2024
2 checks passed
@lazysoundsystem lazysoundsystem deleted the 2024-gtm-barebones branch April 25, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazysoundsystem lazysoundsystem lazysoundsystem requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@attiks @lazysoundsystem