Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RW-812] Fix external links for jobs/training #654

Merged
merged 1 commit into from
Sep 28, 2023
Merged

[RW-812] Fix external links for jobs/training #654

merged 1 commit into from
Sep 28, 2023

Conversation

orakili
Copy link
Collaborator

@orakili orakili commented Sep 27, 2023

Refs: RW-812

This adds the target and rel attributes to external links to open in new tab for links inside fields using the markdown_editor (ckeditor 5) text format.

Tests.

  1. Checkout the branch, clear the cache, import the config
  2. Create or edit a job or training, add some links in the body starting with https://reliefweb.int and your local domain like https://rwint-local.test.
  3. Add links to external sites
  4. Save
  5. Confirm that the RW (prod and local) links do not have a target and rel attributes
  6. Confirm that the external links have those attributes and open in new tab/window

…ab for links inside fields using the markdown_editor (ckeditor 5) format

Refs: RW-812
@orakili orakili requested a review from left23 September 27, 2023 09:46
@orakili orakili force-pushed the RW-812 branch 2 times, most recently from 745e8cb to c1f160c Compare September 27, 2023 09:54
@github-actions
Copy link

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions PHP 8.2.10 (cli) (built: Sep 2 2023 06:59:22) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.10, Copyright (c) Zend Technologies with Zend OPcache v8.2.10, Copyright (c), by Zend Technologies with Xdebug v3.2.1, Copyright (c) 2002-2023, by Derick Rethans Composer version 2.6.3 2023-09-15 09:38:21
Drupal Logs

Pusher: @orakili, Action: pull_request, Workflow: Run tests

@github-actions
Copy link

Coverage Report

Totals Coverage
Statements: 11.76% ( 1092 / 9286 )
Methods: 11.72% ( 83 / 708 )
Lines: 11.76% ( 1009 / 8578 )

Copy link
Contributor

@left23 left23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described.

@orakili orakili merged commit f6cb1fe into develop Sep 28, 2023
@orakili orakili deleted the RW-812 branch December 8, 2023 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants