[TAAS-18] A maximally viable countries API. #20

pjf · 2017-04-04T11:55:46Z

Example record:

{
    "admin_level": "0", 
    "geolocation": {
        "lat": "32.57533772", 
        "lon": "54.2973284"
    }, 
    "hrinfo_id": "285", 
    "id": "105", 
    "iso2": "IR", 
    "iso3": "IRN", 
    "label": {
        "default": "Iran (Islamic Republic of)", 
        "humanitarianresponse": "Iran, Islamic Republic of", 
        "m49": "Iran (Islamic Republic of)", 
        "reliefweb-api": "Iran (Islamic Republic of)", 
        "reliefweb-short": "Iran"
    }, 
    "m49": "364", 
    "reliefweb_id": "121", 
    "x-alpha-2": "IR", 
    "x-alpha-3": "IRN"
}

This includes PR #18 (the minimal API).

Discussions to be linked to on JIRA when I open a ticket there shortly.

In line with the discussion on JIRA, this *only* exports fields that are in the current API.

This exports all relevant data from our spreadsheet.

emmajane · 2017-04-06T09:16:07Z

taas/config.yml

+
+                # Unofficial but generally used fields. These
+                # default to the ISO code where it exists.
+                x-alpha-2:


These default sounds like an automated defaulting. Is that the case? If not, perhaps this comment could be: "Where there is an ISO code, these fields will contain the same value as the ISO code."

emmajane · 2017-04-06T09:16:43Z

taas/config.yml

+                x-alpha-2:
+                    field:
+                        - x Alpha2 codes
+                        - ISO 3166-2:2013 Alpha 2-Codes


Yes, looks like an automated "failover" if blank...?

emmajane · 2017-04-06T09:17:48Z

taas/config.yml

+                    field: HRinfo ID
+                    optional: True
+
+                # Ditto ReliefWeb


Replace "Ditto" with the full explanation: The old ReliefWeb ID, in case people want to match.

pjf · 2017-04-06T11:28:13Z

@emmajane : Comments updated in 2099c36! Merge imminent. :)

pjf added 2 commits April 4, 2017 21:47

[TAAS-18] A minimum viable countries API.

a79efc1

In line with the discussion on JIRA, this *only* exports fields that are in the current API.

[TAAS-18] A maximially viable countries API

79f8258

This exports all relevant data from our spreadsheet.

emmajane reviewed Apr 6, 2017

View reviewed changes

[TAAS-18] Fixing comments based upon code review.

2099c36

pjf merged commit 08d77b8 into master Apr 6, 2017

pjf deleted the taas-18-tng branch April 6, 2017 11:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TAAS-18] A maximally viable countries API. #20

[TAAS-18] A maximally viable countries API. #20

pjf commented Apr 4, 2017

emmajane Apr 6, 2017

emmajane Apr 6, 2017

emmajane Apr 6, 2017

pjf commented Apr 6, 2017

[TAAS-18] A maximally viable countries API. #20

[TAAS-18] A maximally viable countries API. #20

Conversation

pjf commented Apr 4, 2017

emmajane Apr 6, 2017

Choose a reason for hiding this comment

emmajane Apr 6, 2017

Choose a reason for hiding this comment

emmajane Apr 6, 2017

Choose a reason for hiding this comment

pjf commented Apr 6, 2017