Skip to content
This repository has been archived by the owner on Jul 18, 2023. It is now read-only.

[TAAS-85] Upgrade to Python3 #59

Merged
merged 12 commits into from
Oct 3, 2019
Merged

Conversation

lazysoundsystem
Copy link
Collaborator

https://humanitarian.atlassian.net/projects/TAAS/issues/TAAS-85

A couple of minor changes to prevent errors and to replace the codeclimate tests, detailed on the ticket.

This PR should test whether the Travis changes are okay.

@lazysoundsystem
Copy link
Collaborator Author

Travis did have some comments - including an objection to xenon:

0.08s$ xenon xenon -bB -mA -aA
No command 'xenon' found, did you mean:
 Command 'xeno' from package 'xenomai-runtime' (universe)
xenon: command not found
The command "xenon xenon -bB -mA -aA" exited with 127.

I'm not sure if this can be/ needs to be added back later.

@lazysoundsystem lazysoundsystem requested a review from cafuego June 18, 2019 16:37
@emmajane
Copy link
Contributor

@lazysoundsystem it looks like Xenon measures code complexity: https://pypi.org/project/xenon/. This is arguably good to have but not necessarily required for the project to run...

@lazysoundsystem
Copy link
Collaborator Author

@emmajane - yes, I'm also guessing @cafuego will know what the issue is and we'll be able to re-instate it. (I presumed that having it in requirements.txt is enough for travis to load it and know it exists, but apparently not.)

Plus, I'd have to dive quite a bit deeper into Python to even consider making the code more complex!

@cafuego
Copy link
Contributor

cafuego commented Jun 24, 2019

Hmm, the only xenon I know of is the noble gas :-)

@cafuego
Copy link
Contributor

cafuego commented Jun 24, 2019

Ok, travis says:

ERROR: python-coveralls 2.9.0 has requirement coverage==4.0.3, but you'll have coverage 4.5.3 which is incompatible.
ERROR: xenon 0.5.5 has requirement PyYAML<5.0,>=4.2b1, but you'll have pyyaml 5.1.1 which is incompatible.

So I guess we won't be using it for a while.

@lazysoundsystem
Copy link
Collaborator Author

@cafuego - Looks like we're at an impasse with Xenon - looks like it can't be added back easily, but can we agree that it doesn't need to be added back at this stage?

@teodorescuserban
Copy link
Contributor

It doesn't.

@teodorescuserban teodorescuserban requested review from teodorescuserban and removed request for cafuego October 3, 2019 09:48
@teodorescuserban teodorescuserban merged commit 50fe5eb into master Oct 3, 2019
@teodorescuserban teodorescuserban deleted the taas/85-python2-to-3 branch October 3, 2019 09:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants