-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
Travis did have some comments - including an objection to
I'm not sure if this can be/ needs to be added back later. |
@lazysoundsystem it looks like Xenon measures code complexity: https://pypi.org/project/xenon/. This is arguably good to have but not necessarily required for the project to run... |
@emmajane - yes, I'm also guessing @cafuego will know what the issue is and we'll be able to re-instate it. (I presumed that having it in requirements.txt is enough for travis to load it and know it exists, but apparently not.) Plus, I'd have to dive quite a bit deeper into Python to even consider making the code more complex! |
Hmm, the only xenon I know of is the noble gas :-) |
Ok, travis says:
So I guess we won't be using it for a while. |
@cafuego - Looks like we're at an impasse with Xenon - looks like it can't be added back easily, but can we agree that it doesn't need to be added back at this stage? |
It doesn't. |
https://humanitarian.atlassian.net/projects/TAAS/issues/TAAS-85
A couple of minor changes to prevent errors and to replace the codeclimate tests, detailed on the ticket.
This PR should test whether the Travis changes are okay.