Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Broken scaffold no more #209

Merged
merged 6 commits into from
Jun 23, 2023
Merged

Conversation

SamGuay
Copy link
Member

@SamGuay SamGuay commented Jun 15, 2023

  • When dcm2bids_scaffold was ran multiple times, it appended data inside the generated files multiple times instead of overwriting it when using --force.
  • The URL for the README was the the raw README, so HTML was being parsed, fixed that as well.
  • There was no logging, so I added some, including a tree representation of the output_dir in which the scaffold was done. No additional dependency was added.
  • Create a .bidsignore which include tmp_dcm2bids that is not valid, partially answering a comment brought up in Move tmp directory #195

@SamGuay SamGuay changed the title Fix scaffold [FIX] Broken scaffold no more Jun 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2023

Codecov Report

Merging #209 (62d5e44) into master (86f89e3) will increase coverage by 0.50%.
The diff coverage is 90.69%.

@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
+ Coverage   80.07%   80.57%   +0.50%     
==========================================
  Files          15       15              
  Lines         833      865      +32     
  Branches      137      143       +6     
==========================================
+ Hits          667      697      +30     
- Misses        134      136       +2     
  Partials       32       32              
Flag Coverage Δ
pytest 80.57% <90.69%> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dcm2bids/cli/dcm2bids_scaffold.py 89.74% <90.00%> (+2.24%) ⬆️
dcm2bids/utils/utils.py 82.75% <90.62%> (+3.44%) ⬆️
dcm2bids/utils/io.py 72.00% <100.00%> (-3.87%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - fix pep8 and it's GTG

@arnaudbore arnaudbore merged commit fc78036 into UNFmontreal:master Jun 23, 2023
@SamGuay SamGuay deleted the fix-scaffold branch August 27, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants