Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add possibility to input dicom tar or zip archives #262

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

arnaudbore
Copy link
Contributor

@arnaudbore arnaudbore commented Sep 10, 2023

#256 👍

@arnaudbore arnaudbore requested a review from SamGuay September 10, 2023 03:06
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2023

Codecov Report

Patch coverage: 23.80% and project coverage change: -1.11% ⚠️

Comparison is base (80f58c8) 78.60% compared to head (942ae78) 77.50%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
- Coverage   78.60%   77.50%   -1.11%     
==========================================
  Files          15       15              
  Lines        1019     1040      +21     
  Branches      217      223       +6     
==========================================
+ Hits          801      806       +5     
- Misses        171      187      +16     
  Partials       47       47              
Flag Coverage Δ
pytest 77.50% <23.80%> (-1.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
dcm2bids/cli/dcm2bids.py 55.00% <ø> (ø)
dcm2bids/cli/dcm2bids_helper.py 70.37% <ø> (ø)
dcm2bids/dcm2niix_gen.py 41.46% <20.00%> (-6.93%) ⬇️
dcm2bids/utils/utils.py 83.69% <100.00%> (+0.17%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@SamGuay SamGuay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving this new feature!

Works as supposed on my data!

Optional: That'd be great to allow 7z as well although it often requires another software to be installed.

@arnaudbore arnaudbore merged commit 9496b7a into master Sep 12, 2023
29 checks passed
@arnaudbore arnaudbore deleted the enh_input_archive branch September 12, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants