feat: Credit Username on Approval

[LightDestory]

Prerequisites

• I have read and understood the contributing guide.
• The commit message follows the conventional commits guidelines.
• Tested the changes locally with a real Telegram bot.
• Introduced tests for the changes have been added (for bug fixes / features).
• Docs have been added/updated (for bug fixes / features).
• I have updated the CHANGELOG.rst file with an overview of the changes made.

Description

This PR is a re-implementation of the now abandoned #114.

It follows a new approach: save the credited username when creating the PendingPost object.

(If applicable) Issue closed by this PR

• [ closes Show username during approval when message is with credits #91 ]

Does this PR introduce a breaking change?

• Yes
• No

(If yes) What are the changes that might break existing applications?

The Pending Post database entity has been updated. Migrations script should be performed.

Python version you are using

Python 3.12.0

[TendTo]

For the migration, we can use the following script

--- migration.sql
-- Add column credit_username to table pending_posts
ALTER TABLE pending_post ADD COLUMN credit_username VARCHAR(255) DEFAULT NULL;

to run with run_sql migration.sql spotted.sqlite3

---

While the approach is correct, it introduces some inconsistencies with the current method. Right now the credited username is picked when the spot is sent to the channel.

Telegram-SpottedDMI-Bot/src/spotted/utils/info_util.py

Line 415 in 201bc18

sign = await User(user_id).get_user_sign(bot=self.__bot)

meaning that if the user was not credited before spotting but becomes credited before the admins approve the spot, their username will appear without the admin's knowledge.
The same reasoning applies to the username: it could be changed during the approval time.

[Helias]

merge conflict