Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mp 2459 axios client mocked mode #52

Merged

Conversation

chopachop
Copy link

@chopachop chopachop commented Jul 3, 2024

What is the purpose of this pull request?

Implement Axios mocked environment for future implementation of the mocked requests, etc

What has changed?

added required files for real and mocked Axios environment

Notes for reviewer

I ran Prettier so the majority of changes are from it. Look at the files that were added in the PR to see what's new

Jira links

https://uniwise.atlassian.net/browse/MP-2459

@chopachop chopachop requested a review from naueramant July 4, 2024 11:05
@chopachop chopachop marked this pull request as ready for review July 8, 2024 10:27
Copy link

@rimonnassory rimonnassory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think overall it looks fine.

I want you to look at the inline css and move it out to its own file.

@chopachop
Copy link
Author

I think overall it looks fine.

I want you to look at the inline css and move it out to its own file.

Due to custom way of styling in JoyUI that's used here I can't easily move it out in a separate file

@chopachop chopachop requested a review from rimonnassory July 9, 2024 09:11
@chopachop chopachop merged commit 439fc03 into feature/MP-2381-versioning-dashboard Jul 10, 2024
2 checks passed
@chopachop chopachop deleted the MP-2459-Axios-client-Mocked-mode branch July 10, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants