[MP-2569] remove mysql and depend on s3 only #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IslamMonjid
requested review from
Graloth,
naueramant,
weis611,
Sebsh1,
LindnDK,
nikolai-str and
MohamedNagy22
Graloth
reviewed
Aug 29, 2024
There was a problem hiding this comment.
While it all looks fine to me, I've not been able to find any information on Jira (empty description), and the PR description leaves a lot up to interpretation.
Why do we need to do this?
I'd suggest explaining it more in the PR and Jira descriptions, especially Jira in terms of what was decided on.
This is to help use if we ever need to look back on these changes in the future and need to understand what decisions led to them being made.
Graloth
approved these changes
Aug 29, 2024
Sebsh1
approved these changes
Aug 29, 2024
IslamMonjid
merged commit b3b4fc3
into
feature/MP-2381-POEditor-cache-versioning
2 checks passed
IslamMonjid
deleted the
feature/MP-2381/MP-2569-remove-mysql-and-depend-on-s3-only
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pull request does
Remove mysql and depend on S3 only
Why this pull request is necessary
The service's primary focus is on managing and caching POeditor project versions, not on managing POeditor projects. Therefore, a local database is unnecessary, and using S3 storage alone is sufficient.
MP-2569