cache compiler returns filenames, WIP #54
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #47
I haven't been able to run the new test for this. The download just hangs forever. I'm not sure if AEMO is throttling me or not.
I find the logic in
_dynamic_data_fetch_loop
to be quite confusing. It's likely there's some edge case I haven't considered (e.g. what if the user passesselect_columns
, and there's multiple chunks, and the previous run was for a different format, and ...)Can you please look closely at that?
Or perhaps this change is a good time to refactor that function? e.g. Having a while loop that just tries to download the next chunk until some error happens is a bit confusing.
Why not just do something like: