Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: command card styling tweaks #234

Merged
merged 8 commits into from
Jun 10, 2024
Merged

feat: command card styling tweaks #234

merged 8 commits into from
Jun 10, 2024

Conversation

jaskfla
Copy link
Collaborator

@jaskfla jaskfla commented May 11, 2024 •
edited
Loading

Screenshot 2024-05-12T012229

@jaskfla jaskfla changed the base branch from main to prod May 11, 2024 13:25
sou323
sou323 requested changes May 11, 2024
View reviewed changes
Copy link
Collaborator

@sou323 sou323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good mostly, except when the command doesn't overflow, the spacing doesn't seem to be working properly

image
image

@jaskfla
Copy link
Collaborator Author

jaskfla commented May 11, 2024

Oops, thanks for checking! I’ll get that fixed up

@jaskfla jaskfla requested a review from sou323 May 11, 2024 21:47
sou323
sou323 approved these changes May 11, 2024
View reviewed changes
Copy link
Collaborator

@sou323 sou323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appreciate the tidy up :) looks good to me

@jaskfla jaskfla merged commit 0427ca8 into prod Jun 10, 2024
1 check passed
@jaskfla jaskfla deleted the command-card-tweaks branch June 10, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sou323 sou323 sou323 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaskfla @sou323