Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: set up lint checks that run on PR #30

Merged
merged 12 commits into from
Mar 24, 2024
Merged

ci: set up lint checks that run on PR #30

merged 12 commits into from
Mar 24, 2024

Conversation

hwan513
Copy link
Collaborator

@hwan513 hwan513 commented Mar 24, 2024 •
edited
Loading

This PR will enable the following checks to run on PRs.

  • Semantic PRs. Ensures that PR titles conform to the conventional commits standard.
  • Biome CI. Ensures that code passes formatting, linting and import ordering checks.

Additionally:

  • Adds npm script to both build and run dev servers from the root directory.

Closes #15

@hwan513 hwan513 changed the title ci: set up lint checks that run on PR ci set up lint checks that run on PR Mar 24, 2024
@hwan513 hwan513 changed the title ci set up lint checks that run on PR ci: set up lint checks that run on PR Mar 24, 2024
@hwan513
build: remove .pnpm-store ignore from biome
9fe85b9 
Testing to see if this issue occurs on the GitHub runner as well.
jaskfla
jaskfla requested changes Mar 24, 2024
View reviewed changes
Copy link
Collaborator

@jaskfla jaskfla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be okay with breaking the some of the steps in the lint job out into their own jobs?

Otherwise looks good—thanks for setting this up

.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
jaskfla
jaskfla reviewed Mar 24, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
jaskfla
jaskfla reviewed Mar 24, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
jaskfla
jaskfla reviewed Mar 24, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
jaskfla
jaskfla reviewed Mar 24, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
jaskfla
jaskfla approved these changes Mar 24, 2024
View reviewed changes
Copy link
Collaborator

@jaskfla jaskfla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproving since you’re practically there. Thanks 🙏

@hwan513 @jaskfla
ci: rename step titles to be better
bdee0f7 
Co-authored-by: Jasper Lai <33956381+jaskfla@users.noreply.github.com>
@hwan513 hwan513 merged commit 6a34de7 into main Mar 24, 2024
2 checks passed
@hwan513 hwan513 deleted the ci/set-up-on-pr-checks branch March 24, 2024 10:55
@hwan513 hwan513 mentioned this pull request Mar 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaskfla jaskfla jaskfla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up basic CI: build, lint and format checks on pull request
2 participants
@hwan513 @jaskfla