Added dynamic battery widget #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For bottom to know that there are no batteries on the system, I added the battery::Manager to the options.rs file because here is the first moment bottom verifies battery configuration by reading the config file, which may or may not contain the battery field, but for a better UX, it doesn't matter what bottom finds in the config file now, if it doesn't retrieve battery data, it just ignores the battery widget all together. If needed, it can be adjusted so that if the config file contains the battery field, it will still show the widget.
|
I tested this using macOS and it works. |
alexandruradovici
requested changes
Jan 13, 2023
I guarded the options.rs in two places for battery module that can be missing in the feature list.
alexandruradovici
approved these changes
Jan 13, 2023
|
I think you can send the PR to upstream, place a link to it in the pull request. |
9 tasks
I've sent the PR, I've put a link to this one in there. Thank you for the tip about #cfg directive. |
|
Link ClementTsang#975 |
alexandruradovici
added
the
upstream
The PR was approved. Thank you once again! |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For bottom to know that there are no batteries on the system, I added the
battery::Managerto the options.rs file because here is the first moment bottom verifies battery configuration by reading the config file, which may or may not contain the battery field, but for a better UX, it doesn't matter what bottom finds in the config file now, if it doesn't retrieve battery data, it just ignores the battery widget all together.If needed, it can be adjusted so that if the config file contains the battery field, it will still show the widget even without batteries on the system.
Issue
#1
Testing
If relevant, please state how this was tested. All changes must be tested to work:
It was tested with and without config files on a PC without battery and on a laptop with and without battery installed.
If this is a code change, please also indicate which platforms were tested:
Checklist
If relevant, ensure the following have been met:
cargo fmt)README.md, help menu, doc pages, etc.)