Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional explanation to the already existing chapters #19

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Additional explanation to the already existing chapters #19

wants to merge 12 commits into from

Conversation

TrifanBogdan24
Copy link

@TrifanBogdan24 TrifanBogdan24 commented Jan 8, 2024 •
edited
Loading

Here are some changes I made and my approach of Tour of Rust:

  • a few words about what is Rust and its unique aspects
  • working in terminal with Rust (compiling, running and cargo commands)
  • macros
  • detailed information about data types and collections
  • self and Self in terms of implementing a static / non-static method for a struct
  • how to work with cargo

The new explanations are described both in English and Romanian.

@TrifanBogdan24 TrifanBogdan24 marked this pull request as ready for review January 8, 2024 16:51
@TrifanBogdan24
Copy link
Author

Solved issues:

@TrifanBogdan24 TrifanBogdan24 mentioned this pull request Jan 8, 2024
Closed
Alexe1289
Alexe1289 reviewed Jan 8, 2024
View reviewed changes
lessons/en/chapter_1.yaml Outdated Show resolved Hide resolved
Alexe1289
Alexe1289 reviewed Jan 8, 2024
View reviewed changes
lessons/en/chapter_7.yaml Outdated Show resolved Hide resolved
@TrifanBogdan24
Copy link
Author

Thank you Alexe1289 for the feedback, I hope it is all right now.

alexandruradovici
alexandruradovici requested changes Jan 9, 2024
View reviewed changes
Copy link

@alexandruradovici alexandruradovici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you add the changes to the Romanian translation also?

@TrifanBogdan24
Copy link
Author

Sure. I will translate as soon as possible the new explanations.

@TrifanBogdan24 TrifanBogdan24 marked this pull request as draft January 11, 2024 23:15
mariapana
mariapana suggested changes Jan 13, 2024
View reviewed changes
lessons/en/chapter_4.yaml Outdated Show resolved Hide resolved
lessons/en/chapter_4.yaml Outdated Show resolved Hide resolved
lessons/en/chapter_4.yaml Outdated Show resolved Hide resolved
lessons/en/chapter_4.yaml Outdated Show resolved Hide resolved
lessons/en/chapter_7.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_1.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_1.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_1.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_1.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_1.yaml Outdated Show resolved Hide resolved
@TrifanBogdan24 TrifanBogdan24 marked this pull request as ready for review January 13, 2024 19:06
@alexandruradovici
Copy link

@TrifanBogdan24 please mark the changes that are fixed as resolved.

alexandruradovici
alexandruradovici requested changes Jan 19, 2024
View reviewed changes
Copy link

@alexandruradovici alexandruradovici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format the code in Rust Playground.

lessons/en/chapter_1.yaml Outdated Show resolved Hide resolved
lessons/en/chapter_1.yaml Outdated Show resolved Hide resolved
lessons/en/chapter_2.yaml Show resolved Hide resolved
mariapana
mariapana reviewed Jan 21, 2024
View reviewed changes
Copy link

@mariapana mariapana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The typos, confusing explanations and other similar issues I pointed out a while ago still exist.

@mariapana
Copy link

Both the English and the Romanian versions have typos, missing words or situations where the subject of the phrase is in plural form while the verb is in singular form etc. Besides these issues, I also made a few suggestions regarding the clarity of the explanations (which are not mandatory, but could be helpful for inexperienced learners). You can refer to my older comments for concrete examples.

@alexandruradovici
Copy link

Please rebase.

@TrifanBogdan24
Copy link
Author

@mariapana, I tried correcting the typos.
Do I have your approval before rebasing?

@mariapana
Copy link

Looks good!

@TrifanBogdan24
Copy link
Author

I hope that my branch, fixing, is rebased.

@alexandruradovici
Copy link

Please send this to upstream and place a link here.

@TrifanBogdan24
Copy link
Author

TrifanBogdan24 commented Jan 29, 2024 •
edited
Loading

Sure, here is the link to the upstream: richardanaya#514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandruradovici alexandruradovici alexandruradovici requested changes

@mariapana mariapana mariapana approved these changes

@Alexe1289 Alexe1289 Alexe1289 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TrifanBogdan24 @alexandruradovici @mariapana @Alexe1289