Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input and Output #20

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Input and Output #20

wants to merge 13 commits into from

Conversation

TrifanBogdan24
Copy link

@TrifanBogdan24 TrifanBogdan24 commented Jan 8, 2024 •
edited
Loading

Discussed topics

  • printing text
  • writing text
  • reading text from console
  • command line arguments
  • LINUX environment variables

Solved issue:

The new explanations are described both in English and Romanian.

@TrifanBogdan24 TrifanBogdan24 marked this pull request as ready for review January 8, 2024 17:01
@TrifanBogdan24
Copy link
Author

All the other chapters are not modified

@TrifanBogdan24 TrifanBogdan24 mentioned this pull request Jan 8, 2024
Closed
D9nni
D9nni reviewed Jan 8, 2024
View reviewed changes
lessons/en/chapter_10.yaml Outdated Show resolved Hide resolved
@TrifanBogdan24
Copy link
Author

Thank you D9nni for the feedback, I hope it is all right now.

@alexandruradovici
Copy link

State in the description that you added a chapter to the tutorials.

alexandruradovici
alexandruradovici requested changes Jan 9, 2024
View reviewed changes
Copy link

@alexandruradovici alexandruradovici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify the translations for chapter 10 also.

mariapana
mariapana suggested changes Jan 11, 2024
View reviewed changes
lessons/en/chapter_10.yaml Outdated Show resolved Hide resolved
lessons/en/chapter_10.yaml Outdated Show resolved Hide resolved
lessons/en/chapter_10.yaml Outdated Show resolved Hide resolved
lessons/en/chapter_10.yaml Outdated Show resolved Hide resolved
lessons/en/chapter_10.yaml Outdated Show resolved Hide resolved
lessons/en/chapter_10.yaml Show resolved Hide resolved
lessons/en/chapter_10.yaml Show resolved Hide resolved
lessons/en/chapter_10.yaml Show resolved Hide resolved
lessons/en/chapter_10.yaml Show resolved Hide resolved
lessons/en/chapter_10.yaml Show resolved Hide resolved
D9nni
D9nni suggested changes Jan 12, 2024
View reviewed changes
Copy link

@D9nni D9nni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review for romanian translation.

lessons/ro/chapter_10.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_10.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_10.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_10.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_10.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_10.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_10.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_10.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_10.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_10.yaml Outdated Show resolved Hide resolved
andreigheta
andreigheta suggested changes Jan 12, 2024
View reviewed changes
lessons/ro/chapter_10.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_10.yaml Outdated Show resolved Hide resolved
lessons/en/chapter_10.yaml Outdated Show resolved Hide resolved
lessons/en/chapter_10.yaml Outdated Show resolved Hide resolved
@alexandruradovici
Copy link

@TrifanBogdan24 please mark the changes that you made as resolved.

alexandruradovici
alexandruradovici requested changes Jan 21, 2024
View reviewed changes
Copy link

@alexandruradovici alexandruradovici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename all the chapter_10.yaml files to chapter_11.yaml as all the translations have to shift.

alexandruradovici
alexandruradovici requested changes Jan 23, 2024
View reviewed changes
Copy link

@alexandruradovici alexandruradovici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this so you can send it to upstream.

@TrifanBogdan24
Copy link
Author

I hope that my branch new-chapter is rebased

@TrifanBogdan24
Copy link
Author

Here is the link to the upstream: richardanaya#516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandruradovici alexandruradovici alexandruradovici requested changes

@andreigheta andreigheta andreigheta approved these changes

@D9nni D9nni D9nni approved these changes

@mariapana mariapana mariapana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TrifanBogdan24 @alexandruradovici @mariapana @D9nni @andreigheta