Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPBGE: Improve component UI. #795

Merged
merged 1 commit into from
Sep 1, 2018
Merged

UPBGE: Improve component UI. #795

merged 1 commit into from
Sep 1, 2018

Conversation

panzergame
Copy link
Contributor

Previously the components name was exposed by a property non-editable which
was rendered in light gray and the component box was always expanded.
Also the module name was inaccesible from bpy.

The last issue is simply solved by exposing the "module" string to RNA.
The name property is replaced by a label in the UI. To expanse the box
the property "show_expanded" similar to the logic brick is implemented,
when this property is True, an inner box is generated containing all the
properties.

Fix issue #793.

component_ui_1
component_ui_0

@UnidayStudio
Copy link
Collaborator

Improvements here!! I liked.
What about the button to reload all the components at once? And the Color variable?

Previously the components name was exposed by a property non-editable which
was rendered in light gray and the component box was always expanded.
Also the module name was inaccesible from bpy.

The last issue is simply solved by exposing the "module" string to RNA.
The name property is replaced by a label in the UI. To expanse the box
the property "show_expanded" similar to the logic brick is implemented,
when this property is True, an inner box is generated containing all the
properties.

Fix issue #793.
@youle31
Copy link
Collaborator

youle31 commented Aug 19, 2018

hi, I tested with third person component in your test file @panzergame (component_0.blend). This seems to work fine.

When I open the file I have this message in the console:

Read blend: C:\Users\youle\Desktop\Component_0.blend
Traceback (most recent call last):
File "C:\Users\youle\Desktop\Component_0.blend\test.py", line 1, in
ModuleNotFoundError: No module named 'bge'

Else this is great to have an expand UI

@panzergame
Copy link
Contributor Author

This message is normal, I made the mistake of defining a module of name testwhich is also used by other part of python.

@UnidayStudio
Copy link
Collaborator

Tested and not working proper. I can't Reload components by default:

So we expect that a new user that never heard about blender before and downloaded for the first time that do this (activate the reload in user prefs)? If a new user find out hard to do anything, there is a hugoe chance that they will leave the software and never come back.

If this exists for a safety reason, ok, but make "activate" by default. And who wants to disable, goes to userpref and do this. I'd like to remember that press P and run the game also could be unsafe, but we don't desactivate ingame logic because of this.

@panzergame
Copy link
Contributor Author

Despite the auto exec that is the topic of #809, @UnidayStudio : Do you agree with the UI and the code making it ?

@UnidayStudio
Copy link
Collaborator

Yes!

@panzergame panzergame merged commit af46b84 into master Sep 1, 2018
@panzergame panzergame deleted the ge_component_ui branch October 6, 2018 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants