Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update de.po #1991

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Update de.po #1991

merged 1 commit into from
Oct 6, 2023

Conversation

eltomato89
Copy link
Contributor

Added more german localizations.

Description

However, there are several strings that cannot be localized to german (e.g. "Are you sure you want to remove the"), because
the structure of the text would be wrong. (I assume the example "Are you sure you want to remove the" is followed by something like "virtual machine" or "disk" or smth)

Also, there are .. lets say "weird ones" (like "Can reboot clones own virtual machines.")

Anyhow .. this PR adds some more german translations ..

Tags: localization, hacktoberfest

Added more german localizations
@frankiejol
Copy link
Member

Wonderful ! Thank you very much @eltomato89 . It is very interesting your comment about problems with the translations. We have to change these strings so it can be translated correctly to other languages, not only german. I create another issue to address that.

@frankiejol frankiejol added hacktoberfest localization translation and localization labels Oct 6, 2023
@frankiejol frankiejol self-assigned this Oct 6, 2023
@frankiejol frankiejol self-requested a review October 6, 2023 07:04
Copy link
Member

@frankiejol frankiejol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terrific job !

@frankiejol frankiejol merged commit 427eb22 into UPC:main Oct 6, 2023
1 check passed
@frankiejol
Copy link
Member

Also @eltomato89 I am concerned about the other problem you spotted. I created a new issue #1995 . I am wondering if we understood you correctly. Please if you could shed some light about this topic ?

@eltomato89
Copy link
Contributor Author

It was about the structure of that scentence .. but I think I was just missing the context. All good for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants