Update Korean Translation #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @frankiejol, I translated the Korean file but the GitHub checks have been failing and i don't know why. Could you please look into it? |
frankiejol
requested changes
Oct 16, 2023
There was a problem hiding this comment.
First of all thank you very much for your submission, it looks amazing.
Then there are a couple of errors, it looks like at line 337, the " is missing at the end of the string, but there are two of them at the beginning. Similar errors are reported by the automatic check at lines: 394, 425 and 880
|
Hi @frankiejol, thank you all the checks have passed. Can you please review it? |
frankiejol
approved these changes
Oct 18, 2023
amparorvd
approved these changes
Oct 18, 2023
amparorvd
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the Korean translations to the untranslated string
Motivation and Context
Fixes #1988