Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing Suite #2

Open
JamesDearlove opened this issue Jun 5, 2021 · 5 comments
Open

Testing Suite #2

JamesDearlove opened this issue Jun 5, 2021 · 5 comments
Labels
enhancement update an existing command or cog for some new functionality

Comments

@JamesDearlove
Copy link
Member

Off the back of #1, it would be good to have a testing suite in place. Seperate issue created for discussion.
campbell-mcfadden added a commit that referenced this issue Jul 18, 2022
@campbell-mcfadden
Merge pull request #44 from UQComputingSociety/react-to-join
aa080ea 
react-joins #2
@katrinafyi katrinafyi mentioned this issue Nov 13, 2022
Open
@49Indium
Copy link
Member

49Indium commented Apr 5, 2023

How would we like tests to work? There is a test folder currently; do we want to have tests for all components?

@JamesDearlove
Copy link
Member Author

@49Indium Ideally we should test things that are within our control. For example how the events are parsed from the ical, rather than testing if a message is sent.

@49Indium
Copy link
Member

49Indium commented Apr 7, 2023

I've added tests (that pass) for Haiku. Will add some for the other cogs soon.

@49Indium
Copy link
Member

49Indium commented Apr 7, 2023

Looking at this further, it seems that we might need to relocate some of the logic of some commands to their own functions (not within the object) to be able to test them effectively without simulating discord (see here).

@andrewj-brown andrewj-brown added the enhancement update an existing command or cog for some new functionality label Jul 13, 2023
@andrewj-brown
Copy link
Member

linking this library for if/when we ever get the time. This looks to be the "best" (most up-to-date and still live) discord mocking library: https://github.com/CraftSpider/dpytest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement update an existing command or cog for some new functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@49Indium @JamesDearlove @andrewj-brown