Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo automated tests #2

Closed
wants to merge 31 commits into from

Conversation

couryrr-afs
Copy link

@shankari working to get build of images created.

Signed-off-by: Daniel Moore <9156191+drmrd@users.noreply.github.com>
Signed-off-by: Daniel Moore <9156191+drmrd@users.noreply.github.com>
Copy link

@shankari shankari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test itself is fine. But all the images here needs to be us-joet until we finally start hosting the images on everest.

@@ -2,12 +2,12 @@ version: "3.6"

services:
mqtt-server:
image: ghcr.io/shankari/everest-demo/mqtt-server:0.0.1
image: ghcr.io/everest/everest-demo/mqtt-server:0.0.1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this in the US-JOET organization until the new image building process is in place

Suggested change
image: ghcr.io/everest/everest-demo/mqtt-server:0.0.1
image: ghcr.io/us-joet/everest-demo/mqtt-server:build_pkg_task_1_features

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shankari I was planning to updated the remaining in their respective branches.

Copy link

@shankari shankari Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@couryrr-afs can you revert the extraneous changes then? I don't want to have a lot of flip-flopping that is merged, and it clutters up the review.

I am fine with merging once extraneous changes have been cleaned up/removed.

image: ghcr.io/shankari/everest-demo/manager:0.0.2
image: ghcr.io/everest/everest-demo/manager:0.0.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

LABEL org.opencontainers.image.source=https://github.com/shankari/everest-demo
LABEL org.opencontainers.image.source=https://github.com/everest/everest-demo

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs to be us-joet for now until we have the image pipeline, and all the related permissions, integrated into everest

manager/tests/startup_tests.py Show resolved Hide resolved
Comment on lines 142 to 144
charging_session_cmd = {'value': 'sleep 1;iec_wait_pwr_ready;sleep 1;draw_power_regulated 16,3;sleep 5;pause;sleep 5;diode_fail;sleep 5'}
expected_events = ['TransactionStarted', 'ChargingStarted','ChargingPausedEV', {'error': 'CarDiodeFault'}]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, for my understanding, the main change here, over the startup_tests.py in everest-core is that everest-core has a set of hardcoded commands. Here, after initializing the modules, we also send the sequence of commands and expect a sequence of events (with the corresponding changes to ProbeModule, of course).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The biggest change is that we were only getting high level events back. I updated the array to pass back either the event name or a dict with more details. This allows for deeper assertions in the test. There is way more that could probably be done but this proved we could inspect more using the stand alone probe module.

@couryrr-afs couryrr-afs requested a review from shankari November 28, 2023 15:00
drmrd and others added 18 commits December 1, 2023 20:25
Signed-off-by: Daniel Moore <9156191+drmrd@users.noreply.github.com>
Improvements to the manager Dockerfile
Signed-off-by: Daniel Moore <9156191+drmrd@users.noreply.github.com>
Signed-off-by: Daniel Moore <9156191+drmrd@users.noreply.github.com>
Signed-off-by: Daniel Moore <9156191+drmrd@users.noreply.github.com>
Signed-off-by: Daniel Moore <9156191+drmrd@users.noreply.github.com>
Signed-off-by: Daniel Moore <9156191+drmrd@users.noreply.github.com>
Signed-off-by: Daniel Moore <9156191+drmrd@users.noreply.github.com>
Signed-off-by: Daniel Moore <9156191+drmrd@users.noreply.github.com>
Signed-off-by: Daniel Moore <9156191+drmrd@users.noreply.github.com>
Signed-off-by: Daniel Moore <9156191+drmrd@users.noreply.github.com>
See actions/runner#1533

Signed-off-by: Daniel Moore <9156191+drmrd@users.noreply.github.com>
Signed-off-by: Daniel Moore <9156191+drmrd@users.noreply.github.com>
Signed-off-by: Daniel Moore <9156191+drmrd@users.noreply.github.com>
Signed-off-by: Daniel Moore <9156191+drmrd@users.noreply.github.com>
Signed-off-by: Daniel Moore <9156191+drmrd@users.noreply.github.com>
Simplify the current CI/CD workflow
Signed-off-by: Daniel Moore <9156191+drmrd@users.noreply.github.com>
@drmrd drmrd force-pushed the demo-automated-tests branch from 7ce57e8 to 6b09d38 Compare December 6, 2023 01:49
shankari and others added 5 commits December 5, 2023 22:02
Update the ISO 15118-2 DC demo with -2 message logs
Signed-off-by: Daniel Moore <9156191+drmrd@users.noreply.github.com>
…age-tags-being-pushed

Correct the tags output by the Docker metadata action
Signed-off-by: Daniel Moore <9156191+drmrd@users.noreply.github.com>
Signed-off-by: Daniel Moore <9156191+drmrd@users.noreply.github.com>
drmrd and others added 6 commits December 6, 2023 10:32
Signed-off-by: Daniel Moore <9156191+drmrd@users.noreply.github.com>
Increase the power drawn in the ISO 15118-2 DC demo to 160 kW
Signed-off-by: Daniel Moore <9156191+drmrd@users.noreply.github.com>
Signed-off-by: Coury Richards <146002925+couryrr-afs@users.noreply.github.com>
Signed-off-by: Daniel Moore <9156191+drmrd@users.noreply.github.com>
Signed-off-by: Daniel Moore <9156191+drmrd@users.noreply.github.com>
Signed-off-by: Daniel Moore <9156191+drmrd@users.noreply.github.com>
@drmrd drmrd force-pushed the demo-automated-tests branch from 6542f8e to 954b5d2 Compare December 6, 2023 19:24
@drmrd
Copy link

drmrd commented Dec 6, 2023

Closing in favor of EVerest#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants