Clean up API urls by eliminating basepath from the wrong location. #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually the camel case thing might take a bit more. The provided plugin requires all paths to be lower case, which defeats our purpose of making sure downstream functions and such end up camel case for client generators. |
|
well, the latest version of Javalin has a simple "caseInsenstiveRoutes" options, but requires java 11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be handling camel case of "TimeSeries" next as I believe the OpenAPI corrections should be one PR; will squash them to two different commits though before merge.
Solution was quite simple, don't mix up OpenAPI 2.x and OpenAPI 3.x configuration. After reading https://swagger.io/docs/specification/v3_0/api-host-and-base-path/ I realized we've just been doing it wrong because we were keeping old information around; that wasn't even being used anymore.
Partial fix of #818