LocationLevel retrieve constant values in time window #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t values. Includes tests to verify functionality
MikeNeilson
previously approved these changes
Sep 30, 2024
adamkorynta
requested changes
Oct 3, 2024
| @@ -344,6 +316,12 @@ public void getAll(@NotNull Context ctx) { | |||
| + "specified), as well as the time zone of any times in the response." | |||
| + " If this field is not specified, the default time zone of UTC " | |||
| + "shall be used."), | |||
| @OpenApiParam(name = START, type = Instant.class, description = "Specifies the start of the time " | |||
There was a problem hiding this comment.
Adding a start and end date for getOne does not make sense to me as it conflicts with the effective date parameter.
There was a problem hiding this comment.
That's fair, but because there are multiple effective dates there does need to be a way to retrieve them all without it necessarily being a "timeseries" as that's a different concept (seasonal, etc) of location level.
There was a problem hiding this comment.
I don't see how that's different than the behavior of the getAll endpoint.
There was a problem hiding this comment.
We'll see how Daniel responds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #599, LocationLevel retrieve constant values in time window. Includes tests to verify functionality