Bugfix/996 default formats #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a string caused the browser default not to match the default for anything from a browser that had a priority parameter in it.
MikeNeilson
added
the
approved-W192HQ23F0232-task4
rma-rripken
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After deploying and querying data in a browser I notice we were getting a not formatter available message. This was caused by, at least in firefox, the catch all being
*/*;q=0.8instead of just*/*so with the ContentTypeAliasMap beingString,ContentType.Changed it to
ContentType,ContentTypeso that our looser equals (ignoring all parameters except version) would apply.Also had to update some tests as the FireFox Accept string I borrowed has
application/xmlat a higher priority than the catch all.