Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traduccion de src/controllers/write/categories.js de JS a TS" #16 #45

Open
wants to merge 4 commits into
base: f24
Choose a base branch
from

Conversation

JoseAlfonzo99
Copy link

(resolves #16 ) En el archivo se realizaron los siguientes cambios para hacer una traducción completa de JS a TS:

  • Se modificaron los imports y exports para que sean acordes a la sintaxis de TypeScript

  • Se implementaron las interfaces Params,Request,Response, WatchStateRequest

  • Se agregaron los comentarios // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment,, @typescript-eslint/no-unsafe-member-access para poder ignorar las advertencias de lint ya que se utilizan archivos que no se han traducido

  • Se arreglaron los errores de identacion

  • Se uso en los debidos casos el tipado de unknown y así se corrigió el uso de any

  • Se modifico el archivo tsconfig.json de es6 a es2017.

Las pruebas que se realizaron fueron:

  • npm run lint, el cual no ocasiono ningún error

  • npm run test, el cual origina y muestra una cobertura alta y buena

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11317594716

Details

  • 70 of 71 (98.59%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 82.674%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/controllers/write/categories.js 70 71 98.59%
Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
Totals Coverage Status
Change from base Build 11313630816: 0.003%
Covered Lines: 22339
Relevant Lines: 25599

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convirtiendo src/controllers/write/categories.js de JS a TS
2 participants