Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor shell completion scripts + add fish comletion #556

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

folliehiyuki
Copy link

What this PR does:

  • Add fish completion script
  • Move shell completion scripts into 1 place scripts/shell-completion (they are renamed to the correct filenames on the user system)
  • Add support to install completion scripts when running make install

NOTE:

  • I'm not familiar with configure so the PR (apart from the fish completion script) is just me copying blindly what has been done with bash-completion.
  • I tried adding fish completion for rules, partial rules and ids (from the output of usbguard list-devices and usbguard list-rules) but fish complains that there are too many arguments. Adding completion for the IDs alone seems pretty useless (with no indication of what the device with that ID is) so I give up on this topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant