Fix CI and RuleSet::assignID regressions
#628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 4, 2024
Closed
.. because the build started failing. Symptom was (with line breaks added): > /usr/lib/gcc/x86_64-alpine-linux-musl/10.3.1/../../../../x86_64-alpine-linux-musl/bin/ld: > /usr/lib/gcc/x86_64-alpine-linux-musl/10.3.1/../../../../lib/libqb.so: unknown type [0x13] section `.relr.dyn' > /usr/lib/gcc/x86_64-alpine-linux-musl/10.3.1/../../../../x86_64-alpine-linux-musl/bin/ld: > skipping incompatible /usr/lib/gcc/x86_64-alpine-linux-musl/10.3.1/../../../../lib/libqb.so when searching for -lqb Dependency Bash is no longer installed by default with 3.20, so it needs installation now.
Commit 3672e9f changed the return value of `RuleSet::assignID` from "return x++" to "return ++x" which broke CI and skipped value 0. This commits restores the old behavior. This approach does not win prices in purity, elegance or performance, but performance doesn't matter in that function and you are invited to claim those prices for yourself if you can prvide a pull request that humans understand and that fully passes existing CI...
Cropi
reviewed
Jun 5, 2024
radosroka
approved these changes
Jun 6, 2024
Cropi
approved these changes
Jun 6, 2024
|
Thank you! 🙏 |
hartwork
changed the title
RuleSet::assignID regressionsRuleSet::assignID regressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.