cmake: drop -Werror from c++ flags #337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same here, broken in v1.2.1 with gcc-6.1 on OpenSUSE: Alternatively, you could add an cmake option, e.g DONT_INJECT_WERROR. |
|
I think the best solution to this would be adding a cmake option. |
|
Done |
AzothAmmo
added a commit
that referenced
this pull request
Oct 11, 2016
AzothAmmo
added a commit
that referenced
this pull request
Oct 11, 2016
|
Merged into develop; I modified the logic so that the option isn't a negation (DONT_INJECT -> WITH_WERROR). Default is to use Werror, as you had. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting
-Werrorin by default is very bad. Nobody knows what warning future compilers will show!