Fix for #416, compilation warnings for implicit-falltrough on gcc7.1 #427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After checking external/rapidjson/internal/regex.h, I've decided to copy same pragmas instead of relying on the inclusion of regex.h because regex.h pops back the pragmas at the end of the file (although not for gcc), and thus it would be better to change these pragmas per-file basis.
It passes all the tests with gcc7.1.1 on my machine and a simple test code generates no warnings on clang4.0
However whole project fails to build on clang4.0 giving an unrelated error. I will check it as well and send a pull request if I can.
And a suggestion: maybe we can define a macro like CEREAL_FALLTHROUGH that expands to C++17 counterpart if it is defined and to nothing otherwise.