Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #416, Implicit falltrough warning on GCC7.1 (Re-sending) #432

Merged
merged 3 commits into from
Sep 7, 2017
Merged

Fix for #416, Implicit falltrough warning on GCC7.1 (Re-sending) #432

merged 3 commits into from
Sep 7, 2017

Commits on Sep 4, 2017

  1. Workaround for #416 

    Instead of adding std::fallthrough, this one disables
implicit-fallthrough warnings via pragma push/pop mechanism
    @furkanusta
    furkanusta committed Sep 4, 2017
    Configuration menu
    Copy the full SHA
    f698f33 View commit details
    Browse the repository at this point in the history

  2. Added missing implicit fallthrough pragma (Related to #416) 

    Also, this one fixes the forgotten pragma pop at the end of the header file
    @furkanusta
    furkanusta committed Sep 4, 2017
    Configuration menu
    Copy the full SHA
    01dd76f View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2017

  1. Changed 'and' 'or' operators with their symbolic counterparts 

    Apparently literal words cause problems in MSVC
    @furkanusta
    furkanusta committed Sep 7, 2017
    Configuration menu
    Copy the full SHA
    f7baa90 View commit details
    Browse the repository at this point in the history