Add flag to join response name to approval?

[torrin47]

Since the last enhancement seemed so quick and easy, we're going to try for one more. Could we also request a include_response_name=true flag to join those names to the approval output? If it's a small thing on that end, it saves some extra traffic on our harvesting end.

[tbock]

Well this is a delayed response. Looking at this now. My assumption here is that you would never do include_sponsor_details=false&include_response_name=true

If that is the case then would be easier to just combine into a single query param include_all_details=true.

Then you would get something along the lines of

{
            "id": 1,
            "response": {
                "id": 1,
                "users": [
                    2
                ],
                "name": "Response Name",
                "assignable_groups": [
                    "ffffffff-ffff-ffff-ffff-fffffffffffff"
                ],
                "authoritative_group": "ffffffff-ffff-ffff-ffff-fffffffffffff",
                "default_reason": "Citizen Advisor",
                "role": "asdfasdfasdf",
                "requester": 2
            },
            "reason": "Citizen Advisor",
            "sponsor": {
                "id": 2,
                "first_name": "Jim",
                "last_name": "Bo",
                "email": "Bo.Jim@domain",
                "username": "BoJim"
            },
            "first_name": "A Real",
            "last_name": "Person",
            "email": "email@address.com",
            "possible_existing_account": "",
            "is_existing_account": false,
            "organization": "Corp.",
            "username": "Username_EPAEXT",
            "username_valid": true,
            "submitted": "2020-06-25T21:44:23.354279Z",
            "approved": "2020-06-29T18:07:51.833022Z",
            "created": "2020-06-29T18:07:52.332986Z",
            "agol_id": "ffffffff-ffff-ffff-ffff-fffffffffffff",
            "role": "asdfasdfasdfasdf",
            "auth_group": "ffffffff-ffff-ffff-ffff-fffffffffffff",
            "groups": [
                "ffffffff-ffff-ffff-ffff-fffffffffffff"
            ]
        }

We can leave the existing query param in place for now and add this. Once you have switched over let us know and we will likely rip out the old param

[tbock]

@torrin47 can this be closed?