Error occuring when users are attempting to approve multiple accounts if those accounts are a mix of new and existing accounts

[tbock]

I believe this is the error encountered by Chris Wharton but need to investigate further to fully reproduce.

[tbock]

@tommckennon please replicate the issue first and let me know. Maybe we should use our own Portal to replicate this?

[tommckennon]

@tbock , I take it this is a bug within the v1/account/approvals/approve api call. First thought about this bug is that the user shouldn't be able to make this call for existing accounts, correct? It looks like logic has been in place to prevent such an action from occurring. Perhaps there's a hole in the logic or workflow to prevent this from occurring (i.e prevent approve api call on existing accounts)?

[tbock]

There is a hole in the logic. The "approve" for existing accounts is certainly a misnomer but it they are being "approved" in the context of the application.

[tommckennon]

@tbock, the committed backend unit tests added to tests.py that we discussed for the request account approval workflow looks to have have tracked down the bug occurring when users attempt to approve multiple accounts that are a mix of new and existing accounts (#76). If such a request is made, it will always "Error creating and updating accounts". The following simple change looks to resolve the issue. Beyond this unit testing, do we want to verify against our own Portal as this time?