handling gaps #11
Open
handling gaps #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Second commit filters the data so that gap lines and data lines are drawn separately. Hover still doesn't work - need to figure out how to link the gap + data line so they can keep their styling when hovered over. Switching to other data types has weird functionality right now, but rank seems to work just fine. |
|
I think it's because I still need to include |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #7.
This first commit is a bit of a hack. I put one group of lines that is styled with dashes, than a second group styled solid that skips missing data using
.defined. Other than not having the hovers increase the stroke-width of the dashed lines, this works. However, creates a lot of unnecessary elements, so I'm still searching for a better way.