Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summerize
this pull request supports particles which is an instance of MadParticle to be bloomed, but this is
not important. This pr mainly introduced a pipeline that does bloom and merges bloom results into the origin image. You can bloom anything by the pipeline, just making a proper change.
Imporat things
currently, extra light's second component will also be set
and when it is greater than 1.001f(hardcode in the shader), we consider it should participate in the bloom pipeline.
Most bloom related stuffs are located in
BloomManager
with detailed comments, see them if you needNote
this pr only supports the instance OIT pipeline, others are not yet supported.
works under sodium and other things that need future tests.
If you have seen code in shimmer, you may find that the shader code is similar, that is true. So if this pr was merged, you could add mention to that project in a way you like.
If you need more help, contact me recently. I may be busy soon.