-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Load user personnel data into portal #1088
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
51872d7
working state for loading user personnel data
abbyoung ef694ec
merge main
abbyoung 8089e16
set personnel data in auth context
abbyoung 1551459
update unit tests
abbyoung e7e7dbf
fix lint error
abbyoung 29bc22b
add error handling in case personnel api cannot be reached
abbyoung fa226c6
more error handling work
abbyoung 9e58c95
Merge branch 'main' into sc-2264-load-user-personnel-data
abbyoung f49851e
Merge branch 'main' into sc-2264-load-user-personnel-data
abbyoung dfa325f
adding some error logging and logic to try and pinpoint e2e failure
abbyoung 1cfcae8
adding in logs to figure out why a duplicate user is happening
abbyoung 2080b4d
more debugging
abbyoung 0c7042f
remove debugging statements, fix accessing personnel data object
abbyoung 99c10cb
no log in eslint now that debugging is done
abbyoung d1c473b
remove another debug
abbyoung dd84979
add personnel api url to sysinfo
abbyoung 9eda97e
merge
abbyoung f35edd3
fix: ensure myspace is not rendered before user logs in
gidjin 1d43001
Merge branch 'sc-2345/fix-myspace-flash-bug' into sc-2264-load-user-p…
jcbcapps File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,20 +33,20 @@ beforeEach(() => { | |
return { | ||
user: testUser1, | ||
portalUser: testPortalUser1, | ||
loading: false | ||
loading: false, | ||
} | ||
}) | ||
}) | ||
|
||
describe('ThemeToggle component', () => { | ||
test('renders nothing if no user', async () => { | ||
jest.spyOn(useUserHooks, 'useUser').mockImplementation(() => { | ||
return { | ||
user: null, | ||
portalUser: null, | ||
loading: true, | ||
} | ||
}) | ||
jest.spyOn(useUserHooks, 'useUser').mockImplementation(() => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. more formatting weirdness in test files 🥲 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So many, I wonder how all these were missed? Maybe we got a new version of prettier that does a better job? |
||
return { | ||
user: null, | ||
portalUser: null, | ||
loading: true, | ||
} | ||
}) | ||
renderWithAuthAndApollo(<ThemeToggle />, {}) | ||
|
||
expect(screen.queryByTestId('theme-toggle')).toBeNull() | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure what is happening with all of these formatted commas in files I did not even touch 🤨