Change the grades aggregation to account for course versioning #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikehquan19
commented
Oct 25, 2024
|
I have commited the change. |
jpahm
approved these changes
Oct 30, 2024
2 tasks
jpahm
added a commit
that referenced
this pull request
Nov 4, 2024
* Bump develop to Go 1.23 * Update security definition for gateway * Add auto spec generation for swagger endpoint * Make swagger endpoint unauthenticated; fix host * Update x-google-endpoint name * Update spec to match new endpoint * Fix developer API info * Change the grades aggregation to account for course versioning (#231) * Change the grades aggregation to account for course versioning * Fix the parsing of the sample course in grades aggregation * Changed autocomplete endpoint to pull from DAG database and created dynamic Autocomplete schema (#233) * Prep for deployment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've changed the courses aggregation to account for course versioning, essentially querying all of the courses with with same
internal_course_numbereven when they have different combination ofsubject_prefixandcourse_number. For example,ECS 2390andECS 3390will be pulled at the same time because they are different versions of the same class.I pulled one sample course from
courseCollectionwith givenprefixandnumberparameters, gotInternal_course_numberof that course, and filtered the courses usingInternal_course_numberin$matchstage of the pipeline.Let me know ASAP if there's anything I need to fix. Thanks!