-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add undo functionality with ctrl+z #676
Conversation
Vercel Preview URL 🚀 : https://planner-88necyynh-utdnebula.vercel.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks okay aside from a few bugs here and there. As discussed on Discord, we shouldn't undo for filters and selections though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like there's a build error in a weird spot. Could you sync with develop? #679 changes the implementation of handleDeleteAllSelectedCourses
.
Vercel Preview URL 🚀 : https://planner-dsmnty4h6-utdnebula.vercel.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like deleting a course from a semester can't be undone atm. I think we should have that.
Also, do you think you could add an undo for mass deletion of selected courses? Overall looks good though! Can't wait to see this in prod
Vercel Preview URL 🚀 : https://planner-khgvecyph-utdnebula.vercel.app |
Vercel Preview URL 🚀 : https://planner-5uretmwum-utdnebula.vercel.app |
Resolves #673
Essentially creates an undo stack reducer with callbacks that perform the opposite operation of any user action (
handle*
functions). So far seems to be working, however, I will perform some more manual testing before merging.