Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NP 71 Scroll Functionality in Course Search #706

Merged
merged 3 commits into from
Oct 10, 2023
Merged

NP 71 Scroll Functionality in Course Search #706

merged 3 commits into from
Oct 10, 2023

Conversation

rennyhoang
Copy link
Contributor

Overview

Search limit has been increased from 5 -> 100, and max height/overflow handling was used to implement scrolling while searching for courses.

@rennyhoang rennyhoang requested a review from a team as a code owner October 9, 2023 15:39
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Copy link
Member

@cubetastic33 cubetastic33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@cubetastic33 cubetastic33 merged commit c3943a5 into develop Oct 10, 2023
5 checks passed
@cubetastic33 cubetastic33 deleted the NP-71 branch October 10, 2023 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants