Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SKEDGE-13 #35

Merged
merged 3 commits into from
Jul 16, 2024
Merged

SKEDGE-13 #35

merged 3 commits into from
Jul 16, 2024

Conversation

KimotoNari
Copy link
Contributor

Fix for professor inject

@KimotoNari
Updated Inject Professor Name
262de59 
changed empty professor names to "No Instructor"
demonlexe
demonlexe approved these changes Aug 26, 2023
View reviewed changes
src/content.ts Outdated Show resolved Hide resolved
@Jake3231
Copy link
Contributor

@KimotoNari Is this PR good to merge (maybe with the suggested change)?

@KimotoNari
Copy link
Contributor Author

Sorry, didn't see this till recently, merge should be good with the suggested change

@Jake3231 @demonlexe
Nit
2097653 
Co-authored-by: Alexis Kaufman <alexiskaufman@gmail.com>
iamwood
iamwood approved these changes Feb 22, 2024
View reviewed changes
Copy link

@iamwood iamwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TyHil TyHil changed the base branch from main to develop July 16, 2024 19:01
@TyHil TyHil merged commit 657bc8d into UTDNebula:develop Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demonlexe demonlexe demonlexe approved these changes

@iamwood iamwood iamwood approved these changes

Assignees

@iamwood iamwood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KimotoNari @Jake3231 @iamwood @demonlexe @TyHil