-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/display git sha on page in previewdev environments #107
Merged
Jake3231
merged 17 commits into
develop
from
feature/display-git-sha-on-page-in-previewdev-environments
Oct 12, 2023
Merged
Feature/display git sha on page in previewdev environments #107
Jake3231
merged 17 commits into
develop
from
feature/display-git-sha-on-page-in-previewdev-environments
Oct 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Jake3231
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great!
…wdev-environments
Jake3231
deleted the
feature/display-git-sha-on-page-in-previewdev-environments
branch
October 12, 2023 17:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #43
Adds a button on all preview deployment pages to visit the commit on GitHub that triggered the deployment.
What Changed
Only changes
pages/_app.tsx
to place the button on all pages. Uses theNEXT_PUBLIC_VERCEL_GIT_COMMIT_SHA
Vercel environment variable to link to the correct commit andNEXT_PUBLIC_VERCEL_ENV
to determine when to show the button.