288 bug handle null rmp data #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@TyHil in relation to our other convo about no grade data, should we show some message that this prof has no RMP data? |
|
@George-Zhang5246 this professor still has a rmp, just no one filled it out. So ig it's a frontend thing to format it to not show the -1 and stuff |
|
Hmm yeah I suppose it should maybe just say reviews: 0 and have the link to the RMP page |
|
I guess I can do that, though it would need modifications to all of the components as opposed to just the RMP scraper. |
changed tables with rmp data
George-Zhang5246
force-pushed
the
288-bug-handle-null-rmp-data
branch
from
1b6505d
to
7a09c54
Compare
AbhiramTadepalli
approved these changes
Nov 8, 2024
This reverts commit c855a03.
TyHil
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #288
What Changed
ratemyprofessorScraper now gives an error when the rmp data contains 0 ratings.