-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix browser nav & remove the need to double-ENTER on the searchbar #298
Conversation
…avigation easier to use
…query to the searchbar
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@TyHil could you look over these questions? |
Idk what questions but I like all of these changes. What do you think of the commit I made to do the page title without an extra state? Also, intentional choice to capitalize UTD TRENDS? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TyHil sorry they were unpublished
…it can be dynamic with regard pageTitle
Nice!
yes, but what do you think? 11e2a2f the link preview says "Results - UTD Trends" and skips over pageTitle |
This reverts commit 673bbf4.
yeah i don't think it can be dynamic re: capitalization seems good, just needs to be changed in _app and _document to match will look at questions soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Address inline code comments
- Make
og:title
tag not dynamic - Standardize capitalization
…o fix-browser-nav
|
… pageTitle. The useState hook updates when router.query.searchTerms changes, and since the <title> relies on dynamicPageTitle, it gets updated automatically.
…ofessor). Also fix improper slicing in link preview
…in getServerSideProps and in a Dashboard useEffect for router.query.searchTerms
…unction dynamically for <title>; use SSR-generated pageTitle for the og:title meta tag
alright alright alright. This PR does: (4) Dynamic Link Previews:
|
2 things to note re: [Feature Request] Search Engine Optimization (SEO)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Browser Nav:
Searchbar ENTER: