Remove styleguide #329
Draft
Remove styleguide #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@NishilJ if you have any luck getting |
|
@NishilJ do you think we need StyleGuides or should we remove em? |
|
@NishilJ we're keeping em right? |
|
I think it is valuable for documentation, if you think so, my pr would replace this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I don't think anyone knows how to use the
react-styleguidiststuff. I was added in a couple commits in 2022 and hasn't been touched since then. The main benefit I see of it is it allows README documents to render components they are documenting which would be nice.What Changed
Removed the
styleguideandstyleguidistDocsfolders, thestyleguide.config.jsfile, and a bunch of packages inpackage.json. I'm not sure how many of the packages being removed were needed forreact-styleguidistand how many were just unused.