Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/legend #133

Merged
merged 1 commit into from
Jun 21, 2018
Merged

feature/legend #133

merged 1 commit into from
Jun 21, 2018

Conversation

jgonggrijp
Copy link
Member

Implements #95.

@jgonggrijp jgonggrijp self-assigned this Jun 19, 2018
@jgonggrijp jgonggrijp requested a review from alexhebing June 19, 2018 15:39
alexhebing
alexhebing reviewed Jun 20, 2018
View reviewed changes
client/style/main.sass
float: right

.plyr
margin-bottom: 12px


// standard margin for google maps controls that shouldn't touch the edge
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is time I installed a linter for sass files... 😊
Thanks for cleaning up after me this time 👍

alexhebing
alexhebing previously approved these changes Jun 20, 2018
View reviewed changes
Copy link
Contributor

@alexhebing alexhebing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@alexhebing alexhebing dismissed their stale review June 20, 2018 14:28

I noticed something that I think needs a change

@alexhebing
Copy link
Contributor

OK, I don't see how to add to my earlier review (after dismissing it) but:
I noticed the legend is placed directly to the side of the screen (i..e no margin between the edge of the screen and the legendView):
review_legend

Could this be moved to the right (I think 10px does it)?

@jgonggrijp
Copy link
Member Author

Let's find out! 😀

@jgonggrijp
Copy link
Member Author

The viewport option (bottom of table) looks like it should do the trick, but it doesn't work and won't be fixed. The record detail popovers suffer from the same problem.

Could potentially be fixed by moving to Bootstrap 4, but I don't think it's worth the effort.

@alexhebing
Copy link
Contributor

I agree, nevermind...

@jgonggrijp jgonggrijp merged commit 08fa62c into develop Jun 21, 2018
@jgonggrijp jgonggrijp deleted the feature/legend branch June 21, 2018 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexhebing alexhebing alexhebing left review comments

Assignees

@jgonggrijp jgonggrijp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgonggrijp @alexhebing