Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export deregularise as pip package #3

Merged
merged 5 commits into from
May 25, 2022
Merged

Export deregularise as pip package #3

merged 5 commits into from
May 25, 2022

Conversation

oktaal
Copy link
Member

@oktaal oktaal commented Mar 31, 2022

Ik had om dit werkend te krijgen in deregularise.py de import van config relatief gemaakt. Misschien maakt dat sasta stuk dus dat is spannend. Het pip-gedeelte is lokaal te testen als volgt:

pip install -e ~/src/sastadev/pypi/
# Obtaining file:///home/sheean/src/sastadev/pypi
# Installing collected packages: sastadev
#  Attempting uninstall: sastadev
#    Found existing installation: sastadev 0.0.1
#    Uninstalling sastadev-0.0.1:
#      Successfully uninstalled sastadev-0.0.1
#  Running setup.py develop for sastadev
#Successfully installed sastadev
python
# Python 3.8.10 (default, Mar 15 2022, 12:22:08) 
# [GCC 9.4.0] on linux
# Type "help", "copyright", "credits" or "license" for more information.
from sastadev.deregularise import correctinflection
result = correctinflection('slaapten')
print(result)
# [('sliepen', 'Overgeneralisation')]

@JeltevanBoheemen
Copy link
Contributor

Creative solution. The absolute import for config.py causes problems though. Not only for SASTA, but also when running sastadev.py (@JanOdijk's entry point). SASTA hacks the sastadev directory into the path on loading, can we do something like this for the pypi solution?

@oktaal
Copy link
Member Author

oktaal commented May 18, 2022

Does this work for SASTA?

@JeltevanBoheemen
Copy link
Contributor

Yep this works

@oktaal oktaal merged commit b6d64e1 into master May 25, 2022
@oktaal oktaal deleted the feature/pypi branch July 26, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants