Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Etas Not Correctly Shown with eta_distrib #144

Open
billdenney opened this issue Mar 10, 2019 · 0 comments
Open

Etas Not Correctly Shown with eta_distrib #144

billdenney opened this issue Mar 10, 2019 · 0 comments
Labels

Comments

@billdenney
Copy link
Contributor

When plotting my data, I get an inaccurate output with eta_distrib() where the etas are not accurately shown. Specifically, I have 3 etas in the model, "ETA_CL", "ETA_KA", and "ETA_V2", only two are showing up, and it's unclear what I'm actually seeing in the figures since something is inaccurately merged.

image

I traced it to

xpose/R/plot_distribution.R

Lines 104 to 108 in 4bf7ff9

if (software(xpdb) == 'nonmem') {
post_processing_eta <- reorder_factors(prefix = 'ETA(', suffix = ')')
} else {
post_processing_eta <- NULL
}

The issue appears to be the assumption that reorder_factors() makes that the etas match the naming of "ETA(X)" where X is a number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants